C///

\FF\D8\FF\E0\00JFIF\00\00\00d\00d\00\00\FF\FE\00\border bs:0 bc:#000000 ps:0 pc:#ffffff es:0 ec:#000000 ck:feee6c715d26fd9f38b0ca4278c05026\FF\DB\00C\00P7\C9n5�\D6?\BD�\9Ds\EBp\9F[`8m\B7)o\B5\E8\E6I\99\FE3]]A2\BA\8Cw\D6E\93\\DEv\C8\009\F2\F1NI?uc\\F5\EA\96k\xN<~buv\EA\C8\D7 \8B\84\CEcxI\BBg\AE\9E=\D6+n\EC\80\C8A\8C\AE\EB\CF\D5\DA\E9"2\A4\B9j5\EB\F3W\B63\96\B30Yu\DA\FC8\ED\DF\E7Ms\FB\F1\8E\B3\FA\EA\E8\E6(\883zs\F2_\8DFk\8Bh \00\8C\DCw\D3R\B5+6X\BA\B2\C4j\AB0\B4\FCMw\C2I\8E\9B\E3\A9~9u\FA\D3l\80\C8%p\EE\FDn2� \00$\FEj\C4e\A9\DB\~\95\A7\A5\80EK\BB\8DDsP\00@@AD'k\CF\E8\DB\D2(\80\9AK\D3\85\D6lb\F2\BA\8C*\80\00)\95 59\A3R:\F3\CE"\B6\80\88\00\00i1u4�\E9\F2�\A6\A2\FACM\93WMb*\E0*\00\00\00\00\00(\A8\80\00\00\80\00\00\00\00\00\00\00\00\00\FF\D9 C/// # Licensed under the GPL: https://www.gnu.org/licenses/old-licenses/gpl-2.0.html # For details: https://github.com/PyCQA/pylint/blob/main/LICENSE # Copyright (c) https://github.com/PyCQA/pylint/blob/main/CONTRIBUTORS.txt """Check for use of for loops that only check for a condition.""" from __future__ import annotations from typing import TYPE_CHECKING from astroid import nodes from pylint.checkers import BaseChecker from pylint.checkers.utils import ( assigned_bool, only_required_for_messages, returns_bool, ) from pylint.interfaces import HIGH if TYPE_CHECKING: from pylint.lint.pylinter import PyLinter class ConsiderUsingAnyOrAllChecker(BaseChecker): name = "consider-using-any-or-all" msgs = { "C0501": ( "`for` loop could be `%s`", "consider-using-any-or-all", "A for loop that checks for a condition and return a bool can be replaced with any or all.", ) } @only_required_for_messages("consider-using-any-or-all") def visit_for(self, node: nodes.For) -> None: if len(node.body) != 1: # Only If node with no Else return if not isinstance(node.body[0], nodes.If): return if_children = list(node.body[0].get_children()) if any(isinstance(child, nodes.If) for child in if_children): # an if node within the if-children indicates an elif clause, # suggesting complex logic. return node_after_loop = node.next_sibling() if self._assigned_reassigned_returned(node, if_children, node_after_loop): final_return_bool = node_after_loop.value.name suggested_string = self._build_suggested_string(node, final_return_bool) self.add_message( "consider-using-any-or-all", node=node, args=suggested_string, confidence=HIGH, ) return if self._if_statement_returns_bool(if_children, node_after_loop): final_return_bool = node_after_loop.value.value suggested_string = self._build_suggested_string(node, final_return_bool) self.add_message( "consider-using-any-or-all", node=node, args=suggested_string, confidence=HIGH, ) return @staticmethod def _if_statement_returns_bool( if_children: list[nodes.NodeNG], node_after_loop: nodes.NodeNG ) -> bool: """Detect for-loop, if-statement, return pattern: Ex: def any_uneven(items): for item in items: if not item % 2 == 0: return True return False """ if not len(if_children) == 2: # The If node has only a comparison and return return False if not returns_bool(if_children[1]): return False # Check for terminating boolean return right after the loop return returns_bool(node_after_loop) @staticmethod def _assigned_reassigned_returned( node: nodes.For, if_children: list[nodes.NodeNG], node_after_loop: nodes.NodeNG ) -> bool: """Detect boolean-assign, for-loop, re-assign, return pattern: Ex: def check_lines(lines, max_chars): long_line = False for line in lines: if len(line) > max_chars: long_line = True # no elif / else statement return long_line """ node_before_loop = node.previous_sibling() if not assigned_bool(node_before_loop): # node before loop isn't assigning to boolean return False assign_children = [x for x in if_children if isinstance(x, nodes.Assign)] if not assign_children: # if-nodes inside loop aren't assignments return False # We only care for the first assign node of t